Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-main #8

Merged
merged 11 commits into from
Apr 19, 2023
Merged

New-main #8

merged 11 commits into from
Apr 19, 2023

Conversation

eleanorjboyd
Copy link
Owner

fix main

Kartik Raj and others added 11 commits April 17, 2023 11:41
…oft#21062)

In this PR:
1. Changes the python extension logging to use LogOutputChannel
2. Changes the language server logger with LogOutputChannel
3. Test output channel uses OutputChannel as it needs to show test
output and not really logging. Also, using logging test output makes it
pretty much unreadable.
4. Simplifies logging channel and output channel registration.

We need to do this now to make it easier for new test work to integrate
with output logging.

For microsoft#20844

This still doesn't get rid of the log level setting.
closes microsoft#20897
closes microsoft#20084
closes microsoft#20081

---------
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
closes microsoft#21038
also updates the subtests names

---------

Co-authored-by: Kartik Raj <karraj@microsoft.com>
@eleanorjboyd eleanorjboyd merged commit bf3ad2c into main Apr 19, 2023
eleanorjboyd added a commit that referenced this pull request Apr 19, 2023
eleanorjboyd added a commit that referenced this pull request Apr 19, 2023
eleanorjboyd added a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants