Skip to content

Commit

Permalink
fix: resolve CI flakiness due to lzma-native dependency (#8342)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mmaietta
mmaietta committed Jul 16, 2024
1 parent 1c4ec12 commit 60774a3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 219 deletions.
5 changes: 5 additions & 0 deletions .changeset/twenty-pianos-rule.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---

---

fix: resolve CI flakiness due to lzma-native dependency
216 changes: 0 additions & 216 deletions test/snapshots/BuildTest.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -927,199 +927,11 @@ Object {
},
},
},
"node_modules": Object {
"files": Object {
"node-addon-api": Object {
"files": Object {
"LICENSE.md": Object {
"size": "<size>",
},
"common.gypi": Object {
"size": "<size>",
},
"except.gypi": Object {
"size": "<size>",
},
"index.js": Object {
"size": "<size>",
},
"napi-inl.deprecated.h": Object {
"size": "<size>",
},
"napi-inl.h": Object {
"size": "<size>",
},
"napi.h": Object {
"size": "<size>",
},
"node_api.gyp": Object {
"size": "<size>",
},
"noexcept.gypi": Object {
"size": "<size>",
},
"nothing.c": Object {
"size": "<size>",
},
"package-support.json": Object {
"size": "<size>",
},
"package.json": Object {
"size": "<size>",
},
"tools": Object {
"files": Object {
"README.md": Object {
"size": "<size>",
},
"check-napi.js": Object {
"size": "<size>",
},
"clang-format.js": Object {
"size": "<size>",
},
"conversion.js": Object {
"executable": true,
"size": "<size>",
},
"eslint-format.js": Object {
"size": "<size>",
},
},
},
},
},
},
},
"package.json": Object {
"size": "<size>",
},
},
},
"lzma-native": Object {
"files": Object {
"LICENSE": Object {
"size": "<size>",
},
"bin": Object {
"files": Object {
"lzmajs": Object {
"executable": true,
"size": "<size>",
},
},
},
"index.js": Object {
"size": "<size>",
},
"liblzma-build.sh": Object {
"executable": true,
"size": "<size>",
},
"liblzma-config.sh": Object {
"executable": true,
"size": "<size>",
},
"package.json": Object {
"size": "<size>",
},
"prebuilds": Object {
"files": Object {
"darwin-arm64": Object {
"files": Object {
"electron.napi.node": Object {
"size": "<size>",
},
"node.napi.node": Object {
"size": "<size>",
},
},
},
"darwin-x64": Object {
"files": Object {
"electron.napi.node": Object {
"size": "<size>",
},
"node.napi.node": Object {
"size": "<size>",
},
},
},
"linux-arm64": Object {
"files": Object {
"electron.napi.node": Object {
"size": "<size>",
},
"node.napi.node": Object {
"size": "<size>",
},
},
},
"linux-x64": Object {
"files": Object {
"electron.napi.node": Object {
"size": "<size>",
},
"node.napi.node": Object {
"size": "<size>",
},
},
},
"win32-ia32": Object {
"files": Object {
"electron.napi.node": Object {
"size": "<size>",
},
"node.napi.node": Object {
"size": "<size>",
},
},
},
"win32-x64": Object {
"files": Object {
"electron.napi.node": Object {
"size": "<size>",
},
"node.napi.node": Object {
"size": "<size>",
},
},
},
},
},
"src": Object {
"files": Object {
"filter-array.cpp": Object {
"size": "<size>",
},
"index-parser.cpp": Object {
"size": "<size>",
},
"index-parser.h": Object {
"size": "<size>",
},
"liblzma-functions.cpp": Object {
"size": "<size>",
},
"liblzma-node.hpp": Object {
"size": "<size>",
},
"lzma-stream.cpp": Object {
"size": "<size>",
},
"module.cpp": Object {
"size": "<size>",
},
"mt-options.cpp": Object {
"size": "<size>",
},
"util.cpp": Object {
"size": "<size>",
},
},
},
},
},
"mimic-response": Object {
"files": Object {
"index.js": Object {
Expand Down Expand Up @@ -1248,34 +1060,6 @@ Object {
},
},
},
"node-gyp-build": Object {
"files": Object {
"LICENSE": Object {
"size": "<size>",
},
"bin.js": Object {
"executable": true,
"size": "<size>",
},
"build-test.js": Object {
"executable": true,
"size": "<size>",
},
"index.js": Object {
"size": "<size>",
},
"node-gyp-build.js": Object {
"size": "<size>",
},
"optional.js": Object {
"executable": true,
"size": "<size>",
},
"package.json": Object {
"size": "<size>",
},
},
},
"once": Object {
"files": Object {
"LICENSE": Object {
Expand Down
5 changes: 2 additions & 3 deletions test/src/BuildTest.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,13 @@ test.ifDevOrLinuxCi(
copyright: "Copyright © 2018 ${author}",
npmRebuild: true,
onNodeModuleFile: filePath => {
// Force include this directory in the pakage
// Force include this directory in the package
return filePath.includes("node_modules/three/examples")
},
files: [
// test ignore pattern for node_modules defined as file set filter
{
filter: ["!node_modules/napi-build-utils/napi-build-utils-1.0.0.tgz", "!node_modules/node-abi/*"],
filter: ["!node_modules/napi-build-utils/napi-build-utils-1.0.0.tgz", "!node_modules/node-abi/*", "!node_modules/**/eslint-format.js"],
},
],
},
Expand All @@ -350,7 +350,6 @@ test.ifDevOrLinuxCi(
it.dependencies = {
debug: "4.1.1",
"edge-cs": "1.2.1",
"lzma-native": "8.0.6",
keytar: "7.9.0",
three: "0.160.0",
}
Expand Down

0 comments on commit 60774a3

Please sign in to comment.