Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate 7zip-bin chmod logic #7930

Merged
merged 7 commits into from
Dec 8, 2023

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Dec 7, 2023

We use it in multiple locations, and each location requires chmod (due to an issue with dependency missing +x permission), so let's extract it to builder-util since all packages seem to require that. In this way, we enforce it's always accessible and executable

Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 441ca72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
app-builder-lib Patch
builder-util Patch
electron-builder-squirrel-windows Patch
dmg-builder Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch
electron-publish Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 441ca72
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/657258b4e40548000780b9d9
😎 Deploy Preview https://deploy-preview-7930--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit e4d6be8 into master Dec 8, 2023
15 checks passed
@mmaietta mmaietta deleted the chore/consolidate-7zip-chmod-logic branch December 8, 2023 00:47
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant