Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow riscv64 support via custom electron dist #8143

Merged
merged 10 commits into from
Aug 17, 2024
Merged

feat: allow riscv64 support via custom electron dist #8143

merged 10 commits into from
Aug 17, 2024

Conversation

mmaietta
Copy link
Collaborator

Original contributor @kxxt in #7646

Added throwing error when riscv64 binary is not provided via electronDist configuration function or string path

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: dfb757b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
app-builder-lib Major
builder-util Major
electron-builder Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major
electron-publish Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit dfb757b
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66955f86957e710008568e1e
😎 Deploy Preview https://deploy-preview-8143--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator Author

@kxxt, interested in giving this upcoming release a try with the support of riscv64 implementation in electron-builder?

@kxxt
Copy link

kxxt commented Mar 20, 2024

@kxxt, interested in giving this upcoming release a try with the support of riscv64 implementation in electron-builder?

Thanks a lot for bring this up again! Previously I only tested it on riscv64. Today I tested packaging for riscv64 on x86_64 and found one thing I missed: 6ba54e3

@mmaietta
Copy link
Collaborator Author

I'll add that in.

I got your app-builder PR merged in and released develar/app-builder#90 into 5.0.0-alpha.0
We're still blocked on that upgrade in PR due to build issues #8139 so I'll ping you again once that's released

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 20, 2024
@mmaietta mmaietta removed the Stale label May 22, 2024
@mmaietta
Merge branch 'master' into feat/riscv64-support-via-custom-electronDist
2e1ba9b 
# Conflicts:
#	packages/app-builder-lib/src/electron/ElectronFramework.ts
#	test/src/helpers/downloadElectron.ts
@mmaietta
add back semver check for linux ia32
dfb757b
@mmaietta mmaietta merged commit b306895 into master Aug 17, 2024
15 checks passed
@mmaietta mmaietta deleted the feat/riscv64-support-via-custom-electronDist branch August 17, 2024 00:10
@github-actions github-actions bot mentioned this pull request Aug 17, 2024
Merged
@mmaietta mmaietta restored the feat/riscv64-support-via-custom-electronDist branch August 20, 2024 20:44
@mmaietta mmaietta deleted the feat/riscv64-support-via-custom-electronDist branch August 20, 2024 20:44
mmaietta added a commit that referenced this pull request Aug 20, 2024
@mmaietta
Revert "feat: allow riscv64 support via custom electron dist (#8143)"
f2fcc93 
This reverts commit b306895.
@mmaietta mmaietta mentioned this pull request Aug 20, 2024
Merged
mmaietta added a commit that referenced this pull request Aug 20, 2024
@mmaietta
Revert "feat: allow riscv64 support via custom electron dist (#8143)…
de1ea75 
…" (#8427)

This reverts commit b306895.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app-builder-lib builder-util linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmaietta @kxxt