Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appx): Update identityName for windows 10 #8206

Merged
merged 16 commits into from
Jun 8, 2024

Conversation

ifurther
Copy link
Contributor

@ifurther ifurther commented May 7, 2024

  • Split the applicationid and identityname detect function
  • Add auto remove the identityname in Microsoft store has some number in first

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 29b90b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 7, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 29b90b5
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6663a70f7be51c0008ed4741
😎 Deploy Preview https://deploy-preview-8206--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ifurther
Copy link
Contributor Author

ifurther commented May 7, 2024

@mmaietta I updated the test file.

@mmaietta
Copy link
Collaborator

mmaietta commented May 7, 2024

Looks like there's some compilation issues now:

Error: test/src/windows/appxTest.ts(58,9): error TS2353: Object literal may only specify known properties, and 'applicationId' does not exist in type 'WindowsConfiguration'.

@ifurther
Copy link
Contributor Author

ifurther commented May 7, 2024

@mmaietta I removed it

@ifurther
Copy link
Contributor Author

ifurther commented May 8, 2024

@mmaietta Sorry I find the error which is for loop logical.

@ifurther
Copy link
Contributor Author

ifurther commented May 9, 2024

@mmaietta Sorry I fixed the if loop

@ifurther ifurther force-pushed the appx branch 2 times, most recently from c9b0745 to 93e6da5 Compare May 15, 2024 16:28
@ifurther
Copy link
Contributor Author

@mmaietta I check the applicationid and identityname rule and update it.

@ifurther
Copy link
Contributor Author

@mmaietta I updated the replace and find number detection

@ifurther
Copy link
Contributor Author

@mmaietta I found the error and updated it

@ifurther
Copy link
Contributor Author

ifurther commented Jun 1, 2024

@mmaietta I found the error and updated it

@mmaietta
Copy link
Collaborator

mmaietta commented Jun 7, 2024

Looking good! Left a minor comment about a more informative error message, other than that, this will be good to go 🙂

@mmaietta mmaietta merged commit 51111a8 into electron-userland:master Jun 8, 2024
13 checks passed
@ifurther
Copy link
Contributor Author

ifurther commented Jun 9, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants