feat: add custom channel in github provider #8393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f98c2dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
beyondkmp
changed the title
mmaietta
previously approved these changes
Aug 3, 2024
benbucksch
reviewed
Aug 5, 2024
benbucksch
approved these changes
Aug 7, 2024
This was referenced Aug 8, 2024
Merged
benbucksch
added a commit
to mustang-im/mustang
that referenced
this pull request
Aug 15, 2024
In #151, we used a custom update "channel" for parula and mustang. This fixed the uploaded manifest files. But electron-updater client ignored the channel name, therefore pulling the wrong builds. We reported this bug and electron-updater 6.3.3 contains a fix. (Thanks!) electron-userland/electron-builder#8393 electron-userland/electron-builder@8dabf64b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8388