Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RocketCleaner #1205

Merged
merged 49 commits into from
Oct 22, 2019
Merged

feat: add RocketCleaner #1205

merged 49 commits into from
Oct 22, 2019

Conversation

Sanjit1
Copy link
Contributor

@Sanjit1 Sanjit1 commented Sep 30, 2019 •
edited
Loading

Hi! This is a pull request to add @miladdavoodi 's app: RocketCleaner
The apps repository is over here, and the proof that it is using electron is over here.
https://img.shields.io/badge/Keep%20Koding%2C%20Best%20regards-Sanjit-accff2

@Sanjit1 Sanjit1 changed the title feat:add RocketCleaner feat: add RocketCleaner Sep 30, 2019
vhashimotoo
vhashimotoo suggested changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request.

apps/rocketcleaner/rocketcleaner.yml Outdated Show resolved Hide resolved
@Sanjit1
Copy link
Contributor Author

Sanjit1 commented Oct 9, 2019

@ckerr please review

vhashimotoo
vhashimotoo approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the app 💜

Sanjit1 and others added 18 commits October 13, 2019 08:17
vhashimotoo
vhashimotoo approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the app 💛

@vhashimotoo vhashimotoo merged commit 090d458 into electron:master Oct 22, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2023
Open
@rizkimaung rizkimaung mentioned this pull request Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miladdavoodi miladdavoodi miladdavoodi left review comments

@vhashimotoo vhashimotoo vhashimotoo approved these changes

@gargAneesh gargAneesh gargAneesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sanjit1 @miladdavoodi @vhashimotoo @gargAneesh