[Bug]: showItemInFolder hangs macOS Finder for about a minute #38540

nesvet · 2023-06-01T08:15:23Z

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

25.0.1

What operating system are you using?

macOS

Operating System Version

macOS Ventura 13.4

What arch are you using?

x64

Last Known Working Electron version

24.4.0

Expected Behavior

import { shell } from "electron";

shell.showItemInFolder("/path/to/file.ext");

This should open the folder and highlight the file in it

Actual Behavior

In renderer process it leads to Finder's "Not Responding" state for about a minute, and then it show the file. Meanwhile in main process it works as expected

Testcase Gist URL

https://gist.github.com/Nesvet/8700b509a57043453b1e6e027cc0c85e

Additional Information

No response

github-actions · 2023-06-05T19:42:24Z

Hello @nesvet. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

jkleinsc · 2023-06-05T19:44:02Z

@nesvet As documented here: https://www.electronjs.org/docs/latest/api/shell, shell is only available in a non-sandboxed renderer. If you are seeing this issue in a non-sandboxed renderer please provide a gist testcase.

nesvet · 2023-06-05T20:13:09Z

@jkleinsc Hi! Sure, here it is: https://gist.github.com/Nesvet/8700b509a57043453b1e6e027cc0c85e

codebytere · 2023-06-07T14:47:55Z

Looks like this happened here: v25.0.0-nightly.20230330...v25.0.0-nightly.20230331 - likely 3fa0397

mifi · 2023-11-01T12:52:24Z

Having the same problem

Simple test case:

// index.js
const electron = require('electron');

electron.app.whenReady().then(() => {
  const mainWindow = new electron.BrowserWindow({
    webPreferences: {
      contextIsolation: false,
      nodeIntegration: true,
    },
  });

  mainWindow.loadURL('data:text/html;charset=utf-8,<html></html>');
});

Run npx electron index.js
Open developer tools
Type into devtools window.require('electron').shell.showItemInFolder('/Users')
Observe that Finder has frozen
Close the electron app's window
Observe that Finder now responds and shows the requested item in its folder

mifi/lossless-cut#1762

rvion · 2023-11-18T06:44:27Z

This feels like a pretty serious bug. Is there a workaround in the meantime ?

mifi · 2023-11-18T09:01:55Z

Maybe to disable nodeIntegration

KevinHughes · 2023-11-18T11:24:08Z

Here's my workaround, which runs AppleScript behind the scenes:

showItemInFolder(path) {
    let script = `
        set thePath to POSIX file "${path}" as string
        tell application "Finder" to reveal thePath
        tell application "Finder" to activate
    `;
    let process = require('child_process');
    let result = process.execSync("/usr/bin/osascript -", {
        input: script
    });
}

KishanBagaria · 2023-11-18T19:36:02Z

We define the function in main process now and invoke it from renderer. This can be done through https://www.npmjs.com/package/@electron/remote or IPC.

KevinHughes · 2023-11-18T22:26:39Z

We define the function in main process now and invoke it from renderer. This can be done through https://www.npmjs.com/package/@electron/remote or IPC.

I see... I'l do this from now on. I've disabled remote myself for security reasons so am using IPC, but it's working great and would consider this issue closed.

The code for those wondering:

In main:

const { ipcMain, shell } = require('electron');
ipcMain.on('showItemInFolder', function(event, fullPath) {
    shell.showItemInFolder(fullPath);
});

In renderer:

const { ipcRenderer } = require('electron');
ipcRenderer.send('showItemInFolder', fullPath);

Because it's easy for devs to miss this even if electron produces security warnings, I'd suggest that electron should throw a top-level error if these kinds of API calls are made in a sandboxed environment, if it doesn't already.

nesvet added the bug 🪲 label Jun 1, 2023

jkleinsc added the blocked/need-repro Needs a test case to reproduce the bug label Jun 5, 2023

github-actions bot removed the blocked/need-repro Needs a test case to reproduce the bug label Jun 5, 2023

jkleinsc added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 25-x-y labels Jun 6, 2023

codebytere added component/shell status/confirmed A maintainer reproduced the bug or agreed with the feature labels Jun 8, 2023

88250 mentioned this issue Jul 8, 2023

Show in Folder hangs on macOS siyuan-note/siyuan#8705

Closed

3 tasks

MRayermannMSFT mentioned this issue Jul 13, 2023

Open Logs Directory on macOS results in Finder freezing microsoft/AzureStorageExplorer#7066

Closed

mifi mentioned this issue Nov 1, 2023

In LLC 3.58 clicking 'Show file' after export crashes Finder mifi/lossless-cut#1762

Closed

5 tasks

andelf mentioned this issue Nov 21, 2023

Fix fs path handling: open file in folder, open backup folder, Windows UNC path support logseq/logseq#10525

Merged

3 tasks

inukshuk mentioned this issue Dec 6, 2023

Fix clicking on file name to show original photo in Finder tropy/tropy#830

Closed

lyswhut mentioned this issue Dec 8, 2023

[Bug]: crash，MacBook Pro 14 寸 M1 pro 版本，下载列表文件点击文件定位 crash，同时 finder 也卡死无响应 lyswhut/lx-music-desktop#1684

Open

2 tasks

zawata mentioned this issue Jan 11, 2024

[Bug]: await shell.openExternal("https://www.google.com/") not return after the url has been open #39037

Closed

3 tasks

codebytere mentioned this issue May 8, 2024

[Bug]: Finder becomes unresponsive once using shell.showItemInFolder #42082

Closed

3 tasks

codebytere added platform/macOS 29-x-y 30-x-y 31-x-y and removed 25-x-y labels May 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: showItemInFolder hangs macOS Finder for about a minute #38540

[Bug]: showItemInFolder hangs macOS Finder for about a minute #38540

nesvet commented Jun 1, 2023 •

edited by jkleinsc

github-actions bot commented Jun 5, 2023

jkleinsc commented Jun 5, 2023

nesvet commented Jun 5, 2023

codebytere commented Jun 7, 2023

mifi commented Nov 1, 2023

rvion commented Nov 18, 2023

mifi commented Nov 18, 2023

KevinHughes commented Nov 18, 2023

KishanBagaria commented Nov 18, 2023

KevinHughes commented Nov 18, 2023 •

edited

[Bug]: showItemInFolder hangs macOS Finder for about a minute #38540

[Bug]: showItemInFolder hangs macOS Finder for about a minute #38540

Comments

nesvet commented Jun 1, 2023 • edited by jkleinsc

Preflight Checklist

Electron Version

What operating system are you using?

Operating System Version

What arch are you using?

Last Known Working Electron version

Expected Behavior

Actual Behavior

Testcase Gist URL

Additional Information

github-actions bot commented Jun 5, 2023

jkleinsc commented Jun 5, 2023

nesvet commented Jun 5, 2023

codebytere commented Jun 7, 2023

mifi commented Nov 1, 2023

rvion commented Nov 18, 2023

mifi commented Nov 18, 2023

KevinHughes commented Nov 18, 2023

KishanBagaria commented Nov 18, 2023

KevinHughes commented Nov 18, 2023 • edited

nesvet commented Jun 1, 2023 •

edited by jkleinsc

KevinHughes commented Nov 18, 2023 •

edited