Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clicking on file name to show original photo in Finder #830

Closed
inukshuk opened this issue Dec 5, 2023 · 2 comments
Closed

Fix clicking on file name to show original photo in Finder #830

inukshuk opened this issue Dec 5, 2023 · 2 comments
Labels
bug macOS
Milestone
1.16

Comments

@inukshuk
Copy link
Member

inukshuk commented Dec 5, 2023

For some strange reason this blocks almost a minute on macOS. Right-clicking on the photo and showing original file via the context menu works instantly -- so either we're blocking somewhere in Tropy or we use different APIs to hand the file off to the OS.
@inukshuk inukshuk added this to the 1.16 milestone Dec 5, 2023
@inukshuk
Copy link
Member Author

inukshuk commented Dec 6, 2023

Probably an issue with using Electron's shell API in the renderer. We could work around it by forwarding the request to the main process instead.

@inukshuk
Copy link
Member Author

inukshuk commented Dec 6, 2023

Upstream: electron/electron#38540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug macOS
Projects
None yet
Milestone
1.16
Development

No branches or pull requests
1 participant
@inukshuk