Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tooltip component #62

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Create tooltip component #62

merged 2 commits into from
Aug 23, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 23, 2023 •
edited
Loading

@germain-gg germain-gg requested a review from a team as a code owner August 23, 2023 08:04
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51db0a6
Status: ✅  Deploy successful!
Preview URL: https://b048978a.compound-web.pages.dev
Branch Preview URL: https://germain-gg-tooltip.compound-web.pages.dev

View logs

weeman1337
weeman1337 suggested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍

Most comments are only about code comments and the story.

src/components/Tooltip/Tooltip.module.css Show resolved Hide resolved
src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
src/components/Tooltip/Tooltip.test.tsx Show resolved Hide resolved
src/components/Tooltip/Tooltip.stories.tsx Show resolved Hide resolved
src/components/Tooltip/Tooltip.stories.tsx Outdated Show resolved Hide resolved
weeman1337
weeman1337 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@germain-gg germain-gg merged commit 1197a34 into main Aug 23, 2023
7 checks passed
@germain-gg germain-gg deleted the germain-gg/tooltip branch August 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@americanrefugee americanrefugee Awaiting requested review from americanrefugee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Tooltip on Web
2 participants
@germain-gg @weeman1337