Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified grid layout #2325

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Unified grid layout #2325

merged 2 commits into from
Jul 12, 2024

Commits on Jul 3, 2024

  1. Implement the new unified grid layout 

    Here I've implemented an MVP for the new unified grid layout, which scales smoothly up to arbitrarily many participants. It doesn't yet have a special 1:1 layout, so in spotlight mode and 1:1s, we will still fall back to the legacy grid systems.

Things that happened along the way:
- The part of VideoTile that is common to both spotlight and grid tiles, I refactored into MediaView
- VideoTile renamed to GridTile
- Added SpotlightTile for the new, glassy spotlight designs
- NewVideoGrid renamed to Grid, and refactored to be even more generic
- I extracted the media name logic into a custom React hook
- Deleted the BigGrid experiment
    @robintown
    robintown committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    20602c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Address some review feedback

    @robintown
    robintown committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    14fc148 View commit details
    Browse the repository at this point in the history