Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up our tests in preparation for the testing sprint #2466

Merged
merged 29 commits into from
Aug 27, 2024
Merged

Clean up our tests in preparation for the testing sprint #2466

merged 29 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. Fix coverage reporting 

    Codecov hasn't been working recently because Vitest doesn't report coverage by default.
    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    92f52e0 View commit details
    Browse the repository at this point in the history

  2. Suppress some noisy log lines 

    Closes element-hq#686
    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    388980b View commit details
    Browse the repository at this point in the history

  3. Store test files alongside source files 

    This way we benefit from not having to maintain the same directory structure twice, and our linters etc. will actually lint test files by default.
    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9d800a9 View commit details
    Browse the repository at this point in the history

  4. Stop using Vitest globals 

    Vitest provides globals primarily to make the transition from Jest more smooth. But importing its functions explicitly is considered a better pattern, and we have so few tests right now that it's trivial to migrate them all.
    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8adabc0 View commit details
    Browse the repository at this point in the history

  5. Remove Storybook directory 

    We no longer use Storybook.
    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4df10d3 View commit details
    Browse the repository at this point in the history

  6. Configure Codecov 

    Add a coverage gate for all new changes and disable its comments.
    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    230661c View commit details
    Browse the repository at this point in the history

  7. Debug: show hidden roles

    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    82aa3fa View commit details
    Browse the repository at this point in the history

  8. Debug: print screen contents

    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f3c1517 View commit details
    Browse the repository at this point in the history

  9. Debug: try out registering global-jsdom

    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c9a86d2 View commit details
    Browse the repository at this point in the history

  10. Debug: Try making the dialog not be a button

    @robintown @toger5
    robintown authored and toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ba31d82 View commit details
    Browse the repository at this point in the history

  11. prettier for toast files.

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6b5a128 View commit details
    Browse the repository at this point in the history

  12. add jest-dom for vitest

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2ea0f02 View commit details
    Browse the repository at this point in the history

  13. updates to toast.tsx

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b7cdd32 View commit details
    Browse the repository at this point in the history

  14. update to DialogClose

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5fb3156 View commit details
    Browse the repository at this point in the history

  15. debug print esc test

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b6132aa View commit details
    Browse the repository at this point in the history

  16. unmount before escape test

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4e927fa View commit details
    Browse the repository at this point in the history

  17. change order

    @toger5
    toger5 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c58a29b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Remove esc test

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    39405a6 View commit details
    Browse the repository at this point in the history

  2. upgrade vitest

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    bfcab90 View commit details
    Browse the repository at this point in the history

  3. globals

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    41d13eb View commit details
    Browse the repository at this point in the history

  4. runs locally with --no-file-paralllelism

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a4229e6 View commit details
    Browse the repository at this point in the history

  5. grecaptcha lint

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f1e18d3 View commit details
    Browse the repository at this point in the history

  6. remove jsdom dependency

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fb67fd5 View commit details
    Browse the repository at this point in the history

  7. add doc to initDefault.

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9d0a6c5 View commit details
    Browse the repository at this point in the history

  8. revert manual unmount

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    076a768 View commit details
    Browse the repository at this point in the history

  9. fix gracaptcha types

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1d60df5 View commit details
    Browse the repository at this point in the history

  10. cleanup

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f3e46a4 View commit details
    Browse the repository at this point in the history

  11. remove disable next line

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    929ef29 View commit details
    Browse the repository at this point in the history

  12. remove grecaptcha types

    @toger5
    toger5 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    11a7428 View commit details
    Browse the repository at this point in the history