Add numpad accelerators for zooming #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dogancelik, thanks for working on this! Could you please include a sign-off as described here? |
Signed-off-by: Doğan Çelik <dogancelik93@gmail.com>
|
@SimonBrandner Thank you, I added now. |
|
Weird, Cmd + numpad works fine for me on macos without this PR |
|
@t3chguy I think there's an underlying issue in Electron that needs fixing regarding non-English keyboard layouts and key bindings. It's not a critical issue so feel free to close. |
turt2live
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small temporary fix for this issue (element-hq/element-web#9533), because Electron doesn't let you use multiple accelerators yet. Because the numpad menuitems are invisible, they won't show up in the menu but will work like in the example below.
zoom.fix.mp4