Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push notifications are spontaneously disabling themselves #2348

Closed
ara4n opened this issue Mar 26, 2019 · 2 comments · Fixed by matrix-org/matrix-ios-kit#582
Closed

Push notifications are spontaneously disabling themselves #2348

ara4n opened this issue Mar 26, 2019 · 2 comments · Fixed by matrix-org/matrix-ios-kit#582
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression
Milestone
Sprint 19

Comments

@ara4n
Copy link
Member

ara4n commented Mar 26, 2019 •
edited
Loading

We have a regression causing push notifications to silently disable themselves (causing the toggle in Settings to be 'off'). It doesn't seem to be related to updating the app.

Examples i've seen first hand are https://github.com/matrix-org/riot-ios-rageshakes/issues/2157 and https://github.com/matrix-org/riot-ios-rageshakes/issues/2064, although there have been many others. It seems to have started around 0.8.2 or 0.8.1.
@ara4n ara4n added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 X-Regression labels Mar 26, 2019
@manuroe manuroe added this to the Sprint 19 milestone Mar 27, 2019
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Mar 27, 2019
@manuroe
Push: Add logs to track spontaneously disabling
fdb8da0 
element-hq/element-ios/issues/2348
@manuroe manuroe mentioned this issue Mar 27, 2019
Merged
manuroe added a commit that referenced this issue Mar 27, 2019
@manuroe
Push: Add more logs to track spontaneously disabling
774e6c0 
#2348
@manuroe
Copy link
Member

manuroe commented Mar 27, 2019

The last rageshake (https://github.com/matrix-org/riot-ios-rageshakes/issues/2064#issuecomment-477110654) is interesting but we miss logs to determine the issue root.

manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Jul 16, 2019
@manuroe
BF: Push notifications are spontaneously disabling themselves
8c6ac9b 
element-hq/element-ios#2348

Do not reset MXKAccount.enablePushKitNotifications when trying to refresh pushkit pusher at startup.
If the requests fails, the app will consider that push is disabled whereas there is still a pusher on the homeserver.

This is visible at element-hq/element-ios-rageshakes#2618 where the user gets pushes whereas the app setting says there are disabled.

Old logs of element-hq/element-ios-rageshakes#2615 show the same thing but on the last app update, the user lost pushes probably because of lack of refresh of the pusher because MXKAccount.enablePushKitNotifications was NO for a long time.
@manuroe manuroe mentioned this issue Jul 16, 2019
Merged
manuroe added a commit that referenced this issue Jul 16, 2019
@manuroe
Push: Update code to follow API break
8ecf5e7 
#2348
@manuroe manuroe mentioned this issue Jul 16, 2019
Merged
@manuroe
Copy link
Member

manuroe commented Jul 16, 2019

The root bug is around the notification setting at the app level. It has been fixed by matrix-org/matrix-ios-kit@8c6ac9b.

If your notification setting is on in Riot 0.9.0 and later, it will no more spontaneously disable itself.

If your pushes stopped to work when updating to Riot 0.9.0, that means you were impacted by this bug. Re-enable the notification in the app settings. This setting should never go anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging a pull request may close this issue.

BF: Push notifications are spontaneously disabling themselves matrix-org/matrix-ios-kit
2 participants
@ara4n @manuroe