-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polls creation form #5100
Polls creation form #5100
Conversation
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UeJCkB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few a few remarks
-
For each field on focus, we need to make sure the text box is above the composer
-
The text style of titles do not match Figma. Do we have something bolder than that?
-
We need more breathing space between the Poll question/topic section and the Create options section
-
Can you check we have at least 24px between the text box and "add option" button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great stuff here 🔥. Just a few questions/comments.
RiotSwiftUI/Modules/Room/PollEditForm/PollEditFormViewModel.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/Test/UI/PollEditFormUITests.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/Test/Unit/PollEditFormViewModelTests.swift
Outdated
Show resolved
Hide resolved
Seeing as customizing the automatic keyboard avoidance on the textFields is complicated we've agreed to tackle it later, after implement more core functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved given we will tackle the bug with text fields not appearing above the composer when active at later stage.
Thanks!
RiotSwiftUI/Modules/Room/PollEditForm/Test/Unit/PollEditFormViewModelTests.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment regarding the ViewModifier
but LGTM otherwise.
9a662d9
to
eca7a7e
Compare
- added input toolbar poll creation action. - reordered input toolbar actions as per designs. - added multiline text field and extracted common components.
eca7a7e
to
492410a
Compare
Designs
https://www.figma.com/file/tepA3ELWBE5v4O2WB8PqWn/Polls?node-id=247%3A56744
Tickets
https://element-io.atlassian.net/browse/PSF-424
https://element-io.atlassian.net/browse/PSF-317
https://element-io.atlassian.net/browse/PSF-318
How it looks like