Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polls in the timeline #5202

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Polls in the timeline #5202

merged 1 commit into from
Dec 9, 2021

Conversation

stefanceriu
Copy link
Member

  • Added support for rendering polls in the timeline.
  • Introduced new poll bubble cells that render a SwiftUI component on the existing timeline.
  • Integrated the already existing poll builder and aggregator into the PollTimeline coordinator
  • Added polls labs setting
  • increased edit form texts max length
  • linked creation form to poll start events

@stefanceriu
Copy link
Member Author

How they look like
Screenshot 2021-11-26 at 16 22 48
Screenshot 2021-11-26 at 16 23 18
Screenshot 2021-11-26 at 16 28 19
:

@github-actions
Copy link

github-actions bot commented Nov 26, 2021

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ndweSQ

@gaelledel
Copy link

@stefanceriu The build has expired :/

Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to amend the layout for the winner so it looks more like that?
Screenshot 2021-11-30 at 15 26 49

@stefanceriu
Copy link
Member Author

@stefanceriu The build has expired :/

I triggered a new one, can you try again please?

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Sorry for number of comments (I seem to always say this 🙄). 2 larger comments:

  • More doc comments please 🥺
  • With the PollTimelineProvider being a singleton, what happens when you push another room on top of the existing room and then navigate back (e.g. for a preview or a thread)?

Riot/Assets/en.lproj/Vector.strings Show resolved Hide resolved
Riot/Modules/Room/RoomViewController.m Outdated Show resolved Hide resolved
Riot/Modules/Room/RoomViewController.m Outdated Show resolved Hide resolved
Riot/Modules/Room/RoomViewController.m Show resolved Hide resolved
@stefanceriu
Copy link
Member Author

  • With the PollTimelineProvider being a singleton, what happens when you push another room on top of the existing room and then navigate back (e.g. for a preview or a thread)?
    Not sure how all of that works in relation with the RoomCoordinator but the PollTimelineProvideris set to clear all caches coordinators when the room changes. I did want to have a TimelineProvider per RoomCoordinator but that didn't play well with when the timeline cells would need the poll view.

Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2021-12-02 at 09 40 47

  • We need to update the look of the winning option

  • Seems you have the wrong shade of grey for the outline stroke of options. Can you make sure it is Quinary?

  • Change the order of items in the poll menu

@stefanceriu stefanceriu force-pushed the stefan/polls branch 2 times, most recently from dc62af5 to 1c919db Compare December 6, 2021 07:56
Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you for the changes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants