Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThemeService: add a 'Auto (Black)' theme option #7057

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

ThemeService: add a 'Auto (Black)' theme option #7057

wants to merge 1 commit into from

Conversation

tamcore
Copy link

@tamcore tamcore commented Nov 9, 2022 •
edited
Loading

Closes #5966 and #6959.

Pull Request Checklist

@tamcore
add auto black theme option
b91e8da 
Signed-off-by: Philipp Born <git@pborn.eu>
@tamcore tamcore changed the title add "auto (black)" theme option ThemeService: add a 'Auto (Black)' theme option Nov 12, 2022
@BerndSchmecka
Copy link

Can you request a review?

@tamcore
Copy link
Author

tamcore commented Nov 19, 2022

@BerndSchmecka unfortunately don't have any buttons or whatsoever for that. Also asked in the Matrix channel but didn't get any feedback :(

@BerndSchmecka
Copy link

Oh :( Hopefully someone with write access will find this PR and review it so that everyone can enjoy the black theme only at night ^^

@pixlwave pixlwave added X-Needs-Design May require input from the design team X-Needs-Product Requires input from the product team labels Nov 21, 2022
@daniellekirkwood
Copy link
Contributor

Approved from Product perspective.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellekirkwood daniellekirkwood daniellekirkwood approved these changes

Assignees
No one assigned
Labels
X-Needs-Design May require input from the design team X-Needs-Product Requires input from the product team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Allow choosing "Black" theme as replacement for "Dark" when on "Auto"
5 participants
@tamcore @BerndSchmecka @daniellekirkwood @CLAassistant @pixlwave