Feat: add a build setting flag to always show the server selection screen in login/registration flow. #7541
Conversation
nimau
force-pushed
the
nimau/PSB349_force_hs_selection
branch
from
a23a168
to
fd251ac
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7541 +/- ##
===========================================
- Coverage 12.36% 12.22% -0.15%
===========================================
Files 1646 1646
Lines 163465 163517 +52
Branches 67128 67128
===========================================
- Hits 20213 19983 -230
- Misses 142589 142888 +299
+ Partials 663 646 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
RiotSwiftUI/Modules/Authentication/Common/Service/MatrixSDK/AuthenticationService.swift
Outdated
Show resolved
Hide resolved
nimau
force-pushed
the
nimau/PSB349_force_hs_selection
branch
2 times, most recently
from
7a369ae
to
7d27935
Compare
nimau
force-pushed
the
nimau/PSB349_force_hs_selection
branch
from
7d27935
to
6e251b7
Compare
nimau
requested review from
a team,
Velin92 and
pixlwave
and removed request for
a team and
Velin92
| // Use the homeserver defined by a provisioningLink or by the user (if none is set, the default one will be used) | ||
| let homeserverAddress = authenticationService.provisioningLink?.homeserverUrl ?? authenticationService.state.homeserver.addressFromUser | ||
|
|
||
| // Check if the user must select a server | ||
| if BuildSettings.forceHomeserverSelection, homeserverAddress == nil { |
There was a problem hiding this comment.
First off, good job remembering to check the provisioning link - I would have forgotten about that 😃
However we shouldn't include the addressFromUser here as it alters the intended behaviour where navigating back to the carousel and starting again defaults to matrix.org once more. Could probably remove the let homeserverAddress here, check the provisioning link directly in the if and then call startFlow(flow) like before without an address.
There was a problem hiding this comment.
Ok, I updated it that way.
|
Kudos, SonarCloud Quality Gate passed!
|
This PR adds a flag in the BuildSettings to force the user to set a homeserver url instead of using the default one.