Telemetry | Add additional properties to posthog UTD errors #7776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
approved these changes
Apr 11, 2024
| @@ -103,6 +103,17 @@ class DecryptionFailureTracker: NSObject { | |||
| failure.eventLocalAgeMillis = Int(exactly: eventRelativeAgeMillis) | |||
| failure.trustOwnIdentityAtTimeOfFailure = isSessionVerified | |||
|
|
|||
| let myDomain = userId.components(separatedBy: ":")[1] | |||
There was a problem hiding this comment.
Probably safer to do .last here instead of [1]. Who knows how it can all go wrong and crash.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7776 +/- ##
===========================================
+ Coverage 12.25% 12.27% +0.01%
===========================================
Files 1651 1651
Lines 164133 164167 +34
Branches 67490 67499 +9
===========================================
+ Hits 20116 20148 +32
Misses 143346 143346
- Partials 671 673 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Based on #7775
Last step of #7767
Add the new properties
isMatrixOrg,isFederatedandwasVisibleToUser.Note:
wasVisibleToUseris always true for now, as the UTD are reported only from theEventFormatter.Additional work is needed to report visible vs not visible. This would require to move down the
DecryptionFailureTrackerinto the SDK