Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft logout: Design tweaks #10262

Closed
3 tasks done
turt2live opened this issue Jul 4, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3190
Closed
3 tasks done

Soft logout: Design tweaks #10262

turt2live opened this issue Jul 4, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3190
Assignees
@turt2live
Labels
A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 P1 T-Enhancement

Comments

@turt2live
Copy link
Member

turt2live commented Jul 4, 2019 •
edited
Loading

https://zpl.io/a89QL5x

This is reserved as the last item in the list. Includes adjusting CSS, copy, etc.

  • Fix CSS
  • Fix copy
  • "Delete everything" -> "Clear all data"
@turt2live turt2live added feature P1 A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 labels Jul 4, 2019
@turt2live turt2live mentioned this issue Jul 4, 2019
Closed
@turt2live turt2live added phase:1 and removed phase:1 labels Jul 4, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 4, 2019
@turt2live
Ask for the user's password to rehydrate their soft logged out session
93872e6 
Fixes element-hq/element-web#10236

The changes to the MatrixClientPeg (assign/start) are to permit the SoftLogout page to access the MatrixClientPeg reliably. This is why assign() is called by Lifecycle as an alternative to start().

Minimal design work has been done here. The majority is deferred to element-hq/element-web#10262
@turt2live turt2live mentioned this issue Jul 4, 2019
Merged
@turt2live turt2live self-assigned this Jul 5, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 5, 2019
@turt2live
Dress up the soft logout page to look like the design
ae79ce9 
Fixes element-hq/element-web#10262

Also fixes showing the user ID twice. We might have a User object which helpfully sets the display name to the user ID, so check for that.
@turt2live turt2live mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dress up the soft logout page to look like the design matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live