Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread messages from verified users wiggle on hover #19630

Closed
jryans opened this issue Nov 4, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7090
Closed

Thread messages from verified users wiggle on hover #19630

jryans opened this issue Nov 4, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7090
Assignees
@germain-gg
Labels
A-E2EE-Cross-Signing A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect
Milestone
App team 1.9.5

Comments

@jryans
Copy link
Collaborator

jryans commented Nov 4, 2021

Steps to reproduce

  1. Find a thread message from a (I assume) cross-singing verified user
  2. Hover on the message

Outcome

What did you expect?

While there might be some verified marker, the message should not move on hover.

What happened instead?

The message moves on hover, due to the green line on the left. Maybe it should be removed (unsure), but either way the message should not wiggle.

Screen.Recording.2021-11-04.at.15.54.34.mov

Operating system

macOS

Browser information

Firefox 96

URL for webapp

develop.element.io

Application version

Element version: ef87da5-react-9c8e1d32e205-js-195498e9dbf7 Olm version: 3.2.3

Homeserver

matrix.org

Will you send logs?

No
@jryans
Copy link
Collaborator Author

jryans commented Nov 4, 2021

This seems to be the troublesome code:

image

@SimonBrandner SimonBrandner added A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 4, 2021
@germain-gg germain-gg self-assigned this Nov 4, 2021
@germain-gg germain-gg added this to the App team 1.9.5 milestone Nov 5, 2021
@germain-gg germain-gg mentioned this issue Nov 5, 2021
Merged
@HarHarLinks HarHarLinks mentioned this issue Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-E2EE-Cross-Signing A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect
Projects
None yet
Milestone
App team 1.9.5
Development

Successfully merging a pull request may close this issue.

Update highlighted event line to prevent content jumping matrix-org/matrix-react-sdk
3 participants
@jryans @germain-gg @SimonBrandner