Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread panel and right panel having different widths is jarring with new tabs #20499

Closed
turt2live opened this issue Jan 11, 2022 · 10 comments · Fixed by element-hq/matrix-react-sdk#110
Assignees
Labels
A-Right-Panel A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Enhancement

Comments

@turt2live
Copy link
Member

Personally, I'd like a wide thread panel but a narrow right panel

@germain-gg germain-gg added A-Right-Panel T-Enhancement X-Needs-Info This issue is blocked awaiting information from the reporter labels Jan 12, 2022
@germain-gg
Copy link
Contributor

Could you maybe elaborate a bit more on how this would work?
The resize handle lets you change the right panel size. I believe the decision was to not do that to avoid more content shifts when clicking different things

@toger5
Copy link
Contributor

toger5 commented Jan 13, 2022

I could see how this makes sense if the width is stored per room. If I have a room where threads are used a lot the thread panel will be open there and the right panel for this room will have a large width.

@uhoreg
Copy link
Member

uhoreg commented Apr 20, 2022

Closing for now. Feel free to reopen if you have more input on this issue.

@uhoreg uhoreg closed this as completed Apr 20, 2022
@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2022

I would value this also, not sure how to accomplish this in a Good UX way but I often find myself with either a too-narrow thread view or a too-wide member list

@t3chguy t3chguy reopened this Apr 20, 2022
@t3chguy t3chguy added X-Needs-Design A-Threads S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 20, 2022
@toger5
Copy link
Contributor

toger5 commented Jul 30, 2024

With the recent change of giving the right panel a tab design I find it does not look good if the size changes when pressing on a different tab. (It feels unintentional and as if it is by mistake)

So I think with the tab design the right approach would be to not change the width when clicking a tab. This however yields the challenge how the width can be controlled appropriately.

@t3chguy t3chguy changed the title Thread panel and right panel should be allowed to be different widths Thread panel and right panel having different widths is jarring with new tabs Jul 30, 2024
@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 13, 2024

My suggestion is that we make the right panel the same width for all views and it remembers the size you set it at... This needs internal discussion though to ensure alignment on the change back

@daniellekirkwood daniellekirkwood self-assigned this Aug 13, 2024
@daniellekirkwood
Copy link
Contributor

@americanrefugee recommendation:

  • For normal room views, the sidebar should be 320 px wide by default
  • For a video call in a room, the sidebar should be 420 px and show the chat/timeline
  • Agree that if the user changes the width, it should stay that size no matter which section the user is viewing (in that room)

@t3chguy WDYT? Does this about cover what's needed to move this forwards? Could we play around with a netlify build when there's one available?

@t3chguy
Copy link
Member

t3chguy commented Oct 1, 2024

Sounds good

@daniellekirkwood
Copy link
Contributor

@t3chguy would it be possible to have an event to track if people change the width manually or if folks leave it alone?

We were specifically talking about if someone in a video room makes the right panel wider or thinner, but I think just knowing whether the width was changed and then cross-referencing with the room type would work

@t3chguy
Copy link
Member

t3chguy commented Oct 2, 2024

@daniellekirkwood Sure we can do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Right-Panel A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
6 participants