Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak default right panel size to be 320px except for maximised widgets at 420px #110

Merged
merged 25 commits into from
Oct 4, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 1, 2024

Also add an analytics event

Fixes element-hq/element-web#20499
Requires #99
Requires matrix-org/matrix-analytics-events#111

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/fix/27799

# Conflicts:
#	src/components/views/right_panel/RightPanelTabs.tsx
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/fix/27799

# Conflicts:
#	playwright/e2e/read-receipts/index.ts
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…imised widgets at 420px

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy changed the base branch from develop to t3chguy/fix/27799 October 1, 2024 12:10
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/fix/20499

# Conflicts:
#	playwright/snapshots/crypto/crypto.spec.ts/RoomSummaryCard-with-verified-e2ee-linux.png
#	playwright/snapshots/pinned-messages/pinned-messages.spec.ts/pinned-messages-list-empty-linux.png
#	playwright/snapshots/right-panel/file-panel.spec.ts/empty-linux.png
#	playwright/snapshots/right-panel/notification-panel.spec.ts/empty-linux.png
#	playwright/snapshots/right-panel/right-panel.spec.ts/with-name-and-address-linux.png
#	playwright/snapshots/user-view/user-view.spec.ts/user-info-linux.png
#	src/components/views/right_panel/BaseCard.tsx
#	src/i18n/strings/en_EN.json
#	test/components/structures/__snapshots__/FilePanel-test.tsx.snap
#	test/components/views/right_panel/__snapshots__/BaseCard-test.tsx.snap
#	test/components/views/right_panel/__snapshots__/ExtensionsCard-test.tsx.snap
#	test/components/views/right_panel/__snapshots__/PinnedMessagesCard-test.tsx.snap
#	test/components/views/right_panel/__snapshots__/UserInfo-test.tsx.snap
#	test/components/views/rooms/__snapshots__/ThirdPartyMemberInfo-test.tsx.snap
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
test/components/structures/MainSplit-test.tsx Outdated Show resolved Hide resolved
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
@t3chguy t3chguy enabled auto-merge October 4, 2024 09:06
@t3chguy t3chguy added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@t3chguy t3chguy added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@t3chguy t3chguy added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@t3chguy t3chguy added this pull request to the merge queue Oct 4, 2024
Merged via the queue into develop with commit 0a9b4ae Oct 4, 2024
27 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/20499 branch October 4, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread panel and right panel having different widths is jarring with new tabs
2 participants