Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config.md docs on custom_translations_url #26262

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Improve config.md docs on custom_translations_url #26262

merged 2 commits into from
Oct 2, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 29, 2023 •
edited by github-actions bot
Loading

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy
Improve config.md docs on custom_translations_url
282f58f 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Sep 29, 2023
@t3chguy t3chguy mentioned this pull request Sep 29, 2023
Merged
@t3chguy t3chguy self-assigned this Sep 29, 2023
@Johennes Johennes mentioned this pull request Oct 2, 2023
Closed
3 tasks
@t3chguy t3chguy marked this pull request as ready for review October 2, 2023 10:10
@t3chguy t3chguy requested a review from a team as a code owner October 2, 2023 10:10
@t3chguy t3chguy requested review from dbkr and robintown October 2, 2023 10:10
andybalaam
andybalaam approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github is really angry about this change, but it looks fine to me.

@andybalaam
Copy link
Contributor

Github is really angry about this change, but it looks fine to me.

I.e. the diff view shows everything in red.

@t3chguy t3chguy merged commit c6e1a3d into develop Oct 2, 2023
23 checks passed
@t3chguy t3chguy deleted the t3chguy/localazy-custom-translations branch October 2, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam