Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assets path issue for "compound-design-tokens" package #26636

Closed
wants to merge 1 commit into from
Closed

Fix assets path issue for "compound-design-tokens" package #26636

wants to merge 1 commit into from

Commits on Nov 24, 2023

  1. Fix assets path issue for "compound-design-tokens" package 

    Fixed path issue for "compound-design-tokens" package independent of whether the package is cloned and linked within "matrix-react-sdk" or not.

Resource paths are e.g. ...

- Not linked package -
resourcePath: C:\src\matrix-react-sdk\node_modules\@vector-im\compound-design-tokens\icons\chat-solid.svg

- Cloned & linked package -
resourcePath: C:\src\compound-design-tokens\icons\chat-solid.svg

Problem: 
The "compound-design-tokens" package does not have a 'dist' or "res" subfolder for the assets so that the regex /^.*[/\\](dist|res)[/\\]/ does not match. 

Solution: 
Add the missing root folder name for the compound tokens assets to the regex in the "webpack.config.js" to match the paths, with resulting regex... 

/^.*[/\\](dist|res|compound-design-tokens)[/\\]/

Tested both scenarios (linked/not linked) on Windows.
    @menturion
    menturion authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1f6ca69 View commit details
    Browse the repository at this point in the history