Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.matrix.rustcomponents:sdk-android to v0.2.50 #3565

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 30, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.matrix.rustcomponents:sdk-android 0.2.49 -> 0.2.50 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner September 30, 2024 14:08
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Sep 30, 2024
@renovate renovate bot requested review from jmartinesp and removed request for a team September 30, 2024 14:08
@@ -343,6 +350,7 @@ class RustTimeline(
}

@Throws
@Suppress("UnusedPrivateMember")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this warning suppression here, but maybe it's better to just remove the function?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe just remove it.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/SCUxrZ

@jmartinesp jmartinesp force-pushed the renovate/org.matrix.rustcomponents-sdk-android-0.x branch from 6b8e2af to 120f711 Compare September 30, 2024 16:06
@jmartinesp jmartinesp force-pushed the renovate/org.matrix.rustcomponents-sdk-android-0.x branch from 120f711 to 67eecb0 Compare September 30, 2024 16:17
Copy link
Contributor Author

renovate bot commented Sep 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

We may find a better way to compare data class instance if we need to do more comparison in the future...
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (48a4a9d) to head (f8a40d2).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/libraries/matrix/test/timeline/FakeTimeline.kt 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3565   +/-   ##
========================================
  Coverage    82.68%   82.68%           
========================================
  Files         1732     1732           
  Lines        40974    40975    +1     
  Branches      4964     4964           
========================================
+ Hits         33878    33880    +2     
  Misses        5341     5341           
+ Partials      1755     1754    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the massive work!

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 1, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 1, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmarty for fixing the RoomSummary assertions!

Copy link

sonarcloud bot commented Oct 1, 2024

@bmarty
Copy link
Member

bmarty commented Oct 1, 2024

Thanks @bmarty for fixing the RoomSummary assertions!

NP. It's a bit annoying not having "by default" comparable data class, we will need to find a better/cleaner solution if we need to do this sort of hack at too many places.

@jmartinesp jmartinesp merged commit 3001efb into develop Oct 1, 2024
29 of 30 checks passed
@jmartinesp jmartinesp deleted the renovate/org.matrix.rustcomponents-sdk-android-0.x branch October 1, 2024 07:44
@bmarty bmarty mentioned this pull request Oct 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants