Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image event with no thumbnail or width/height metadata is rendered mangled #2253

Closed
ara4n opened this issue Dec 16, 2023 · 0 comments
Closed
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Dec 16, 2023

Steps to reproduce

Spotted an event which mangles EXI’s timeline. Presumably it’s choking on lack of width & height metadata (or lack of thumbnail)?

image

https://matrix.to/#/!NicAJNwJawmHrEhqZs%3Amatrix.org/%24ECgvT0vk8p0qALRhqCKwC1bjF9RIcmPAky5ai0KLi1A

EventTimelineItem {
    sender: "@benoitj:matrix.org",
    sender_profile: Ready(
        Profile {
            display_name: Some(
                "benoitj",
            ),
            display_name_ambiguous: false,
            avatar_url: Some(
                "mxc://matrix.org/hNUwwmrXNIeKFRckuqURXrml",
            ),
        },
    ),
    timestamp: MilliSecondsSinceUnixEpoch(1702766679145),
    content: Message(
        Message {
            in_reply_to: None,
            thread_root: None,
            edited: false,
            ..
        },
    ),
    kind: Remote(
        RemoteEventTimelineItem {
            event_id: "$ECgvT0vk8p0qALRhqCKwC1bjF9RIcmPAky5ai0KLi1A",
            reactions: {},
            read_receipts: {
                "@benoitj:matrix.org": Receipt {
                    ts: Some(
                        MilliSecondsSinceUnixEpoch(1702766692731),
                    ),
                    thread: Unthreaded,
                },
                "@spwhitton:matrix.debian.social": Receipt {
                    ts: Some(
                        MilliSecondsSinceUnixEpoch(1702767636373),
                    ),
                    thread: Main,
                },
                "@wibjarm:tchncs.de": Receipt {
                    ts: Some(
                        MilliSecondsSinceUnixEpoch(1702766698926),
                    ),
                    thread: Unthreaded,
                },
                "@flaminwalrus:matrix.org": Receipt {
                    ts: Some(
                        MilliSecondsSinceUnixEpoch(1702769470607),
                    ),
                    thread: Main,
                },
            },
            is_own: false,
            is_highlighted: false,
            encryption_info: None,
            origin: Sync,
            ..
        },
    ),
}

{
  "event_id" : "$ECgvT0vk8p0qALRhqCKwC1bjF9RIcmPAky5ai0KLi1A",
  "content" : {
    "body" : "snow.el",
    "filename" : "shot-20231216T174359.png",
    "info" : {
      "mimetype" : "image\/png",
      "size" : 49386
    },
    "url" : "mxc:\/\/matrix.org\/RXQNLFqtNVgYwFgAtOmBqdeP",
    "msgtype" : "m.image"
  },
  "sender" : "@benoitj:matrix.org",
  "type" : "m.room.message",
  "unsigned" : {
    "age" : 342
  },
  "origin_server_ts" : 1702766679145
}

Outcome

What did you expect?

render the image based on the file’s actual width/height?

What happened instead?

mangled layout

Your phone model

No response

Operating system version

No response

Application version

465

Homeserver

No response

Will you send logs?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant