Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send html in plain text mode #2246

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 14, 2023

Requires 2.22.0 version of RTE

Copy link

github-actions bot commented Dec 14, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b5fd95b

@Velin92 Velin92 marked this pull request as ready for review December 14, 2023 16:02
@Velin92 Velin92 requested a review from a team as a code owner December 14, 2023 16:02
@Velin92 Velin92 requested review from pixlwave and removed request for a team December 14, 2023 16:02
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (669141b) 71.38% compared to head (b5fd95b) 71.39%.

Files Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 2 Missing ⚠️
...ens/ComposerToolbar/ComposerToolbarViewModel.swift 81.81% 2 Missing ⚠️
...Screens/ComposerToolbar/View/ComposerToolbar.swift 83.33% 1 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 0.00% 1 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2246   +/-   ##
========================================
  Coverage    71.38%   71.39%           
========================================
  Files          517      517           
  Lines        35410    35408    -2     
  Branches     17048    17038   -10     
========================================
+ Hits         25277    25278    +1     
  Misses        9504     9504           
+ Partials       629      626    -3     
Flag Coverage Δ
unittests 57.41% <68.18%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 2f88d39 into develop Dec 15, 2023
9 checks passed
@Velin92 Velin92 deleted the mauromito/send_html_in_plain_text_mode branch December 15, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants