Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI POC for room list filters #2382

Merged
merged 14 commits into from
Jan 26, 2024
Merged

UI POC for room list filters #2382

merged 14 commits into from
Jan 26, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 25, 2024

This is just a UI preview, the filters won't do anything yet to the room list

fixes #2339
fixes #2340
fixes #2341

Simulator.Screen.Recording.-.iPhone.15.-.2024-01-25.at.12.17.59.mp4

@Velin92 Velin92 requested a review from a team as a code owner January 25, 2024 10:06
@Velin92 Velin92 requested review from stefanceriu and removed request for a team January 25, 2024 10:06
Copy link

github-actions bot commented Jan 25, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e25698e

@Velin92 Velin92 changed the title POC for room list filters UI POC for room list filters Jan 25, 2024
@Velin92 Velin92 added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Jan 25, 2024
Copy link

github-actions bot commented Jan 25, 2024

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zqCPjU

@Velin92 Velin92 requested a review from pixlwave January 25, 2024 10:41
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (29c8049) 73.20% compared to head (e25698e) 73.12%.
Report is 1 commits behind head on develop.

Files Patch % Lines
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 78.46% 14 Missing ⚠️
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 48.14% 10 Missing and 4 partials ⚠️
...s/HomeScreen/View/Filters/RoomListFilterView.swift 86.66% 5 Missing and 1 partial ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 6 Missing ⚠️
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 44.44% 5 Missing ⚠️
.../HomeScreen/View/Filters/RoomListFiltersView.swift 89.74% 4 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2382      +/-   ##
===========================================
- Coverage    73.20%   73.12%   -0.09%     
===========================================
  Files          517      519       +2     
  Lines        35602    35780     +178     
  Branches     17112    17214     +102     
===========================================
+ Hits         26062    26163     +101     
- Misses        8909     8986      +77     
  Partials       631      631              
Flag Coverage Δ
unittests 57.66% <74.24%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo nice 👌

@Velin92 Velin92 enabled auto-merge (squash) January 25, 2024 15:59
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 requested a review from pixlwave January 25, 2024 16:26
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Velin92 Velin92 merged commit 25ec8d2 into develop Jan 26, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/filters_ui branch January 26, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
3 participants