Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple more error messages during authentication. #2497

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

pixlwave
Copy link
Member

This PR adds 2 messages:

Refresh tokens without OIDC Invalid well-known file
Simulator Screenshot - iPhone 15 Pro - 2024-02-23 at 14 37 34 Simulator Screenshot - iPhone 15 Pro - 2024-02-23 at 14 29 44

@pixlwave pixlwave requested a review from a team as a code owner February 23, 2024 14:41
@pixlwave pixlwave requested review from stefanceriu and removed request for a team February 23, 2024 14:41
Copy link

github-actions bot commented Feb 23, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against eea7ad3

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 74.82%. Comparing base (ff35688) to head (eea7ad3).

Files Patch % Lines
...hentication/LoginScreen/LoginScreenViewModel.swift 0.00% 8 Missing ⚠️
...ntication/LoginScreen/LoginScreenCoordinator.swift 0.00% 4 Missing ⚠️
...n/SoftLogoutScreen/SoftLogoutScreenViewModel.swift 0.00% 4 Missing ⚠️
...lectionScreen/ServerSelectionScreenViewModel.swift 25.00% 3 Missing ⚠️
...ctionScreen/ServerSelectionScreenCoordinator.swift 0.00% 2 Missing ⚠️
...SoftLogoutScreen/SoftLogoutScreenCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2497      +/-   ##
===========================================
- Coverage    74.83%   74.82%   -0.01%     
===========================================
  Files          525      525              
  Lines        36612    36632      +20     
  Branches     17497    17429      -68     
===========================================
+ Hits         27397    27411      +14     
- Misses        8997     9002       +5     
- Partials       218      219       +1     
Flag Coverage Δ
unittests 60.39% <4.34%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
19.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late review, lgtm 👍

@pixlwave pixlwave merged commit 1afde10 into develop Feb 27, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/authentication-alerts branch February 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants