Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the existing MockClientProxy with a generated one + special… #2508

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

stefanceriu
Copy link
Member

… configuration options

This will help with consolidating how we handle mocks and provide better configuration options

@stefanceriu stefanceriu requested a review from a team as a code owner February 28, 2024 10:07
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 28, 2024 10:07
Copy link

github-actions bot commented Feb 28, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L235 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L237 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L239 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Screens/HomeScreen/View/HomeScreen.swift#L241 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 98e96a7

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.60%. Comparing base (f5c43ed) to head (98e96a7).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2508      +/-   ##
===========================================
- Coverage    74.63%   74.60%   -0.04%     
===========================================
  Files          533      533              
  Lines        37112    37117       +5     
  Branches     17731    17730       -1     
===========================================
- Hits         27699    27690       -9     
- Misses        9196     9210      +14     
  Partials       217      217              
Flag Coverage Δ
unittests 60.36% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally! LGTM

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.8% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit c8f728c into develop Feb 28, 2024
9 checks passed
@stefanceriu stefanceriu deleted the stefan/clientProxyMock branch February 28, 2024 15:18
stefanceriu added a commit that referenced this pull request Sep 10, 2024
stefanceriu added a commit that referenced this pull request Sep 10, 2024
stefanceriu added a commit that referenced this pull request Sep 11, 2024
#3252)

* Fixes #2508 - Offer user to transition to SSS

* Rename `HomeScreenBannerMode.shown` to `HomeScreenBannerMode.show`

* Generate and use preview tests for the migration banner

* Bump the RustSDK to v1.0.46

* Address PR review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants