Hard code the room flow to a single room proxy. #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 4d2c103 |
pixlwave
force-pushed
the
doug/single-room-flow-coordinators
branch
from
b87e003
to
606aef5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2599 +/- ##
===========================================
+ Coverage 74.43% 74.95% +0.52%
===========================================
Files 572 572
Lines 39034 38934 -100
Branches 16939 16735 -204
===========================================
+ Hits 29054 29183 +129
+ Misses 9980 9751 -229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
doug/single-room-flow-coordinators
branch
from
85826d7
to
5162fbe
Compare
pixlwave
requested review from
Velin92 and
stefanceriu
and removed request for
a team and
Velin92
stefanceriu
approved these changes
Mar 26, 2024
pixlwave
force-pushed
the
doug/single-room-flow-coordinators
branch
from
5162fbe
to
532ef22
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR scopes the responsibility of
RoomFlowCoordinatordown to a single room. Rather than letting it change rooms, it becomes the job ofUserSessionFlowCoordinatorto replace the room flow when necessary.First part of #2587.