Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK and enable event permalinks. #2748

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

pixlwave
Copy link
Member

Handles some encryption API changes too, ready for #2740.

@pixlwave pixlwave requested a review from a team as a code owner April 25, 2024 17:36
@pixlwave pixlwave requested review from stefanceriu and removed request for a team April 25, 2024 17:36
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 522fbcb

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.45%. Comparing base (8d66572) to head (522fbcb).
Report is 2 commits behind head on develop.

Files Patch % Lines
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 7 Missing ⚠️
...ntX/Sources/Application/Navigation/AppRoutes.swift 0.00% 2 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 2 Missing ⚠️
...eens/RoomScreen/RoomScreenInteractionHandler.swift 0.00% 1 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2748      +/-   ##
===========================================
- Coverage    74.76%   74.45%   -0.32%     
===========================================
  Files          580      582       +2     
  Lines        40439    40760     +321     
===========================================
+ Hits         30234    30347     +113     
- Misses       10205    10413     +208     
Flag Coverage Δ
unittests 62.25% <13.33%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit df6cf25 into develop Apr 26, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/enable-event-permalinks branch April 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants