Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide timeline style selection #2968

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Hide timeline style selection #2968

merged 3 commits into from
Jun 26, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 26, 2024

First part of #2964

This will default the timeline style to always be bubble, and will hide to the user the possibility of switching to plain mode.
This PR won't fully remove the plain text code since doing so is a delicate process, which we will do in a follow up PR.

@Velin92 Velin92 requested a review from a team as a code owner June 26, 2024 09:47
@Velin92 Velin92 requested review from stefanceriu and removed request for a team June 26, 2024 09:47
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

github-actions bot commented Jun 26, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c4b369f

@Velin92 Velin92 added the pr-change for updates to an existing feature label Jun 26, 2024
@Velin92 Velin92 enabled auto-merge (squash) June 26, 2024 10:00
Copy link

sonarcloud bot commented Jun 26, 2024

@Velin92 Velin92 disabled auto-merge June 26, 2024 10:42
@Velin92 Velin92 merged commit 342cfc0 into develop Jun 26, 2024
4 of 5 checks passed
@Velin92 Velin92 deleted the remove_plain_mode branch June 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants