Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XcodeGen files for app variants and setup Enterprise submodule. #2976

Merged
merged 11 commits into from
Jun 27, 2024

Conversation

pixlwave
Copy link
Member

This PR makes the following changes:

Configuration

  • Creates an app.yml with the base app variant configuration for XcodeGen.
  • Updates the Fastfile to include overrides for this configuration for Nightly/PR builds.
  • Adds the app's icon to ElementX/target.yml (technically not necessary but nice to reference the default value here).

Enterprise

  • Adds an initial AppHooks mechanism that has an empty implementation but allows for modifying the AppSettings type as a starting point.
  • Add a submodule for EXE.
  • Conditionally import the Fastfile from that module if cloned.

@pixlwave pixlwave added Trigger-PR-Build Uses to trigger alpha builds for PRs pr-build for changes related to build, tools, CI/CD labels Jun 27, 2024
@pixlwave pixlwave requested a review from a team as a code owner June 27, 2024 12:06
@pixlwave pixlwave requested review from Velin92 and removed request for a team June 27, 2024 12:06
Copy link

github-actions bot commented Jun 27, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 1767a76

@pixlwave pixlwave added Trigger-PR-Build Uses to trigger alpha builds for PRs and removed Trigger-PR-Build Uses to trigger alpha builds for PRs labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (41d40d8) to head (1767a76).
Report is 3 commits behind head on develop.

Files Patch % Lines
ElementX/Sources/Hooks/AppHooks.swift 0.00% 8 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 5 Missing ⚠️
ElementX/Sources/Application/AppSettings.swift 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2976      +/-   ##
===========================================
- Coverage    78.05%   77.25%   -0.80%     
===========================================
  Files          693      694       +1     
  Lines        54208    54288      +80     
===========================================
- Hits         42313    41942     -371     
- Misses       11895    12346     +451     
Flag Coverage Δ
unittests 68.49% <5.26%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 27, 2024

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CKo5tQ

Copy link

sonarcloud bot commented Jun 27, 2024

@pixlwave pixlwave merged commit 3cc4145 into develop Jun 27, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/exe branch June 27, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants