Remove plain style layout #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 10b4172 |
Velin92
force-pushed
the
mauroromito/cleanup-plain-mode
branch
from
46e521d
to
39eb040
Compare
pixlwave
approved these changes
Jun 27, 2024
| @@ -51,13 +51,7 @@ struct TimelineItemStatusView: View { | |||
| TimelineDeliveryStatusView(deliveryStatus: .sent) | |||
| } | |||
| case .sendingFailed: | |||
| // Bubbles handle the failure internally, but plain items don't. | |||
There was a problem hiding this comment.
Might be good to leave the comment until we've tidied up the next part.
|
Maybe the title could be a bit more descriptive for a changelog entry though 🤔 |
removed name
Velin92
force-pushed
the
mauroromito/cleanup-plain-mode
branch
from
09e9d77
to
10b4172
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of the plain style removal PR, this only removes the plain case and all the tests and code to related to plain, but does not remove the styling abstraction yet. That will be done in a separate PR so that we can always revert it in case we would need a new style.