Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volatile draft to restore the composer after an edit. #2996

Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 2, 2024

save a volatile draft when editing a message, and restore it after the edit is completed or cancelled

@Velin92 Velin92 requested a review from a team as a code owner July 2, 2024 12:21
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 2, 2024 12:21
Copy link

github-actions bot commented Jul 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 950d795

@Velin92 Velin92 added the pr-feature for a new feature label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 83.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (457bd31) to head (9f4dcf0).

Current head 9f4dcf0 differs from pull request most recent head 950d795

Please upload reports for the commit 950d795 to get more accurate results.

Files Patch % Lines
.../Services/ComposerDraft/ComposerDraftService.swift 0.00% 9 Missing ⚠️
...een/ComposerToolbar/ComposerToolbarViewModel.swift 87.23% 6 Missing ⚠️
...eens/RoomScreen/RoomScreenInteractionHandler.swift 0.00% 1 Missing ⚠️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2996      +/-   ##
===========================================
- Coverage    77.85%   77.80%   -0.06%     
===========================================
  Files          694      694              
  Lines        53834    53911      +77     
===========================================
+ Hits         41913    41943      +30     
- Misses       11921    11968      +47     
Flag Coverage Δ
unittests 68.49% <83.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, only 1 question about clearing.

@Velin92 Velin92 requested a review from pixlwave July 2, 2024 14:00
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

save a volatile draft when editing a message, and restore it after the edit is completed or cancelled
@Velin92 Velin92 enabled auto-merge (squash) July 2, 2024 14:17
@Velin92 Velin92 force-pushed the mauroromito/save_and_restore_draft_before_and_after_edits branch from 72e8bc3 to 950d795 Compare July 2, 2024 14:17
Copy link

sonarcloud bot commented Jul 2, 2024

@Velin92 Velin92 merged commit 94f9834 into develop Jul 2, 2024
6 checks passed
@Velin92 Velin92 deleted the mauroromito/save_and_restore_draft_before_and_after_edits branch July 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants