-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volatile draft to restore the composer after an edit. #2996
Volatile draft to restore the composer after an edit. #2996
Conversation
Generated by 🚫 Danger Swift against 950d795 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2996 +/- ##
===========================================
- Coverage 77.85% 77.80% -0.06%
===========================================
Files 694 694
Lines 53834 53911 +77
===========================================
+ Hits 41913 41943 +30
- Misses 11921 11968 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM, only 1 question about clearing.
ElementX/Sources/Screens/RoomScreen/RoomScreenInteractionHandler.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
save a volatile draft when editing a message, and restore it after the edit is completed or cancelled
72e8bc3
to
950d795
Compare
Quality Gate passedIssues Measures |
save a volatile draft when editing a message, and restore it after the edit is completed or cancelled