Fix for the left room event using member instead of the sender #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against a416917 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3000 +/- ##
===========================================
- Coverage 77.92% 77.87% -0.05%
===========================================
Files 694 694
Lines 53939 53939
===========================================
- Hits 42032 42007 -25
- Misses 11907 11932 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Jul 5, 2024
ElementX/Sources/Services/Timeline/TimelineItems/RoomStateEventStringBuilder.swift
Show resolved
Hide resolved
Velin92
force-pushed
the
mauroromito/fix_left_room_event_string
branch
from
085d80a
to
a416917
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member always contains the display name which is not always available for the sender display name sometimes.
This fix however will only be seen if the current SDK version includes: matrix-org/matrix-rust-sdk#3648