Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old visible rooms range with subscriptions in the room list. #3014

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 8, 2024

This PR does 2 things:

  • Use the visible range publisher once again, this time to add subscriptions to the rooms so we get back the timeline_limit: 20 behaviour.
  • Removes the use of roomListItem.unsubscribe() (and tracking the subscription count) as this won't be part of Simplified Sliding Sync.

Closes #3007.

@pixlwave pixlwave requested a review from a team as a code owner July 8, 2024 11:28
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 8, 2024 11:28
@pixlwave pixlwave added the pr-change for updates to an existing feature label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 59c18ed

@pixlwave pixlwave force-pushed the doug/room-list-subscriptions branch from 6afb3d1 to 59c18ed Compare July 8, 2024 12:10
Copy link

sonarcloud bot commented Jul 8, 2024

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (bf9e1d6) to head (59c18ed).

Files Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3014   +/-   ##
========================================
  Coverage    77.78%   77.78%           
========================================
  Files          695      695           
  Lines        53851    53868   +17     
========================================
+ Hits         41886    41901   +15     
- Misses       11965    11967    +2     
Flag Coverage Δ
unittests 68.60% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit a1329d9 into develop Jul 8, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/room-list-subscriptions branch July 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale room previews are worse with local roomlist sorting
2 participants