Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Element Call uses the correct theme and language. #3017

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 8, 2024

The iOS equivalent of element-hq/element-x-android#3118

Theme Language

@pixlwave pixlwave added the pr-bugfix for bug fix label Jul 8, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 8, 2024 16:36
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 8, 2024 16:36
Copy link

github-actions bot commented Jul 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 04bf0dc

Copy link

sonarcloud bot commented Jul 8, 2024

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (a28536e) to head (04bf0dc).

Files Patch % Lines
...Services/ElementCall/ElementCallWidgetDriver.swift 0.00% 6 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 3 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 3 Missing ⚠️
...ces/Screens/CallScreen/CallScreenCoordinator.swift 0.00% 2 Missing ⚠️
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3017      +/-   ##
===========================================
+ Coverage    77.73%   77.77%   +0.03%     
===========================================
  Files          695      695              
  Lines        53870    53876       +6     
===========================================
+ Hits         41877    41900      +23     
+ Misses       11993    11976      -17     
Flag Coverage Δ
unittests 68.63% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit fe5cea1 into develop Jul 9, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/call-theme-locale branch July 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants