Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same UI as Android when tapping a link to a private room. #3044

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 15, 2024

Don't show a "something went wrong" message, instead show the same UI as Android. Closes #2961

@pixlwave pixlwave added the pr-bugfix for bug fix label Jul 15, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 15, 2024 16:18
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 15, 2024 16:18
Copy link

github-actions bot commented Jul 15, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 50d1863

@pixlwave pixlwave force-pushed the doug/join-private-room branch 2 times, most recently from bb1def4 to 82717fe Compare July 17, 2024 17:04
Copy link

sonarcloud bot commented Jul 18, 2024

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (65dd6f3) to head (50d1863).

Files Patch % Lines
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3044   +/-   ##
========================================
  Coverage    77.96%   77.96%           
========================================
  Files          694      694           
  Lines        54064    54076   +12     
========================================
+ Hits         42149    42160   +11     
- Misses       11915    11916    +1     
Flag Coverage Δ
unittests 68.66% <93.75%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 7fbdc2c into develop Jul 18, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/join-private-room branch July 18, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joining a room you don't have permission to join gives an ugly error
2 participants