Simplify how we setup Sentry to make sure it's configured before any … #3053
Conversation
Generated by 🚫 Danger Swift against aafe2d5 |
| Self.setupSentry(appSettings: appSettings) | ||
|
|
||
| Self.setupServiceLocator(appSettings: appSettings, appHooks: appHooks) | ||
|
|
||
| ServiceLocator.shared.analytics.startIfEnabled() | ||
|
|
There was a problem hiding this comment.
It would be nice to get rid of the service locator's singleton at some point. E.g. looking at the UserSessionStore it references it and whilst that particular method shouldn't be called before this is run it would still be nice to have more compile time safety.
There was a problem hiding this comment.
Yeah, I agree, I didn't particularly enjoy moving these methods around.
…spans get created - they don't get reported otherwise
stefanceriu
force-pushed
the
stefan/sentry
branch
from
e316453
to
aafe2d5
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3053 +/- ##
===========================================
- Coverage 77.93% 77.65% -0.28%
===========================================
Files 695 695
Lines 53997 54208 +211
===========================================
+ Hits 42080 42095 +15
- Misses 11917 12113 +196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…spans get created - they don't get reported otherwise