Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK fixing a few room list bugs. #3054

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Update the SDK fixing a few room list bugs. #3054

merged 3 commits into from
Jul 17, 2024

Conversation

pixlwave
Copy link
Member

I've split the commits up a bit to see API breaks but should be easy enough to review as one.

Closes #3031 and #3034.

@pixlwave pixlwave added the pr-bugfix for bug fix label Jul 17, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 17, 2024 13:28
@pixlwave pixlwave requested review from stefanceriu and removed request for a team July 17, 2024 13:28
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7fc5fd7

Copy link

sonarcloud bot commented Jul 17, 2024

@pixlwave pixlwave changed the title Update the SDK fixing a few room list bug. Update the SDK fixing a few room list bugs. Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (aa71f10) to head (7fc5fd7).

Files Patch % Lines
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 3 Missing ⚠️
...Services/ElementCall/ElementCallWidgetDriver.swift 0.00% 3 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3054      +/-   ##
===========================================
- Coverage    77.76%   77.76%   -0.01%     
===========================================
  Files          695      695              
  Lines        54107    54110       +3     
===========================================
  Hits         42078    42078              
- Misses       12029    12032       +3     
Flag Coverage Δ
unittests 68.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, ship it! 🚀

@pixlwave pixlwave merged commit 95d53f1 into develop Jul 17, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/sdk branch July 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a room whilst the app is syncing takes you to the JoinRoomScreen.
2 participants