Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track sub-spans as transactions as well so that we can plot them on a sentry dashboard #3066

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Jul 19, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner July 19, 2024 07:36
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team July 19, 2024 07:36
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 5367391

Copy link

sonarcloud bot commented Jul 19, 2024

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (3e005c8) to head (5367391).

Files Patch % Lines
...ementX/Sources/Services/Analytics/Signposter.swift 33.33% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3066      +/-   ##
===========================================
- Coverage    77.51%   77.50%   -0.02%     
===========================================
  Files          699      699              
  Lines        54458    54470      +12     
===========================================
+ Hits         42215    42218       +3     
- Misses       12243    12252       +9     
Flag Coverage Δ
unittests 68.56% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit a436ea6 into develop Jul 19, 2024
12 checks passed
@stefanceriu stefanceriu deleted the stefan/sentryPerformanceTracing branch July 19, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants