Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a certificate validator hook. #3069

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Add a certificate validator hook. #3069

merged 4 commits into from
Jul 19, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 19, 2024

This PR contains 2 commits:

  • Add the new hook for use in Element Call web views (default implementation does nothing as usual).
  • Exposes all the hooks for direct use (so we can have multiple methods on them), adds default implementations and tidies up AppHooks.swift into multiple files.

Probably easiest to review commit-by-commit.

@pixlwave pixlwave requested a review from a team as a code owner July 19, 2024 11:44
@pixlwave pixlwave requested review from stefanceriu and removed request for a team July 19, 2024 11:44
Copy link

github-actions bot commented Jul 19, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d00f05e

@pixlwave pixlwave added the pr-misc for other changes label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (74907d3) to head (d00f05e).

Files Patch % Lines
ElementX/Sources/AppHooks/AppHooks.swift 23.52% 13 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 6 Missing ⚠️
...rces/AppHooks/Hooks/CertificateValidatorHook.swift 0.00% 3 Missing ⚠️
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 3 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 2 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 33.33% 2 Missing ⚠️
...ces/Screens/CallScreen/CallScreenCoordinator.swift 0.00% 2 Missing ⚠️
...mentX/Sources/AppHooks/Hooks/AppSettingsHook.swift 0.00% 1 Missing ⚠️
...ntX/Sources/AppHooks/Hooks/ClientBuilderHook.swift 0.00% 1 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3069      +/-   ##
===========================================
- Coverage    77.93%   77.83%   -0.11%     
===========================================
  Files          697      702       +5     
  Lines        54174    54208      +34     
===========================================
- Hits         42222    42193      -29     
- Misses       11952    12015      +63     
Flag Coverage Δ
unittests 68.51% <19.04%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Copy link

sonarcloud bot commented Jul 19, 2024

@pixlwave pixlwave merged commit cdd763e into develop Jul 19, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/certificate-hook branch July 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants