Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementCall unable to access media on ongoing CallKit session. #3077

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner July 22, 2024 13:37
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team July 22, 2024 13:37
Copy link

github-actions bot commented Jul 22, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against cd1a60e

Copy link

sonarcloud bot commented Jul 22, 2024

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (cdd763e) to head (cd1a60e).
Report is 3 commits behind head on develop.

Files Patch % Lines
...rces/Services/ElementCall/ElementCallService.swift 0.00% 20 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3077      +/-   ##
===========================================
- Coverage    78.00%   78.00%   -0.01%     
===========================================
  Files          701      703       +2     
  Lines        54186    54439     +253     
===========================================
+ Hits         42270    42464     +194     
- Misses       11916    11975      +59     
Flag Coverage Δ
unittests 68.59% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed comment 👍

@Velin92 Velin92 added the pr-bugfix for bug fix label Jul 22, 2024
@stefanceriu stefanceriu merged commit b135940 into develop Jul 22, 2024
11 of 12 checks passed
@stefanceriu stefanceriu deleted the stefan/elementCallVideoStreamWorkaround branch July 22, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants