Hide/Show pin banner based on scroll direction #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against b147428 |
Velin92
added
the
pr-wip
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3080 +/- ##
===========================================
- Coverage 78.01% 78.00% -0.02%
===========================================
Files 703 703
Lines 54362 54420 +58
===========================================
+ Hits 42410 42449 +39
- Misses 11952 11971 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
but the transition does not work properly
and improved the hide/show behaviour based on the scroll direction
and fixed a bug with the indicator and improved the tests for it
Velin92
force-pushed
the
mauroromito/pinned_banner_show_hide
branch
from
4b4cd43
to
b147428
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator.Screen.Recording.-.iPhone.15.-.2024-07-23.at.17.47.46.mp4