Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash experienced when trying to report a crash. #3086

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pixlwave
Copy link
Member

Sentry needs to be created after the ServiceLocator because of the onLastCrash closure. Additionally, out Signpost (which lives in the AnalyticsService inside the locator) shouldn't start talking to Sentry until it has been configured.

@pixlwave pixlwave requested a review from a team as a code owner July 25, 2024 14:35
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 25, 2024 14:35
Copy link

github-actions bot commented Jul 25, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 4891c5c

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> 🚪 -> 🚀 -> 💥

@pixlwave pixlwave added the pr-bugfix for bug fix label Jul 25, 2024
@pixlwave pixlwave enabled auto-merge (squash) July 25, 2024 14:38
Copy link

sonarcloud bot commented Jul 25, 2024

@pixlwave pixlwave merged commit 8ff53da into develop Jul 25, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/fix-sentry branch July 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants