generated from element-hq/.github
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto identity reset #3107
Merged
Merged
Crypto identity reset #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 5214282 |
pixlwave
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me. I think it would be nicer if we had a flow coordinator for all this, but not essential. That way we could add the flow (at least with a password) to the UI tests so we know it still works.
ElementX/Sources/Screens/SecureBackup/SecureBackupScreen/SecureBackupScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
PreviewTests/__Snapshots__/PreviewTests/test_identityConfirmationScreen-iPhone-15-en-GB.1.png
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/EncryptionReset/EncryptionResetScreen/View/EncryptionResetScreen.swift
Outdated
Show resolved
Hide resolved
...reens/EncryptionReset/EncryptionResetPasswordScreen/View/EncryptionResetPasswordScreen.swift
Outdated
Show resolved
Hide resolved
...reens/EncryptionReset/EncryptionResetPasswordScreen/View/EncryptionResetPasswordScreen.swift
Outdated
Show resolved
Hide resolved
...Sources/Screens/EncryptionReset/EncryptionResetScreen/EncryptionResetScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
...X/Sources/Screens/EncryptionReset/EncryptionResetScreen/EncryptionResetScreenViewModel.swift
Show resolved
Hide resolved
...X/Sources/Screens/EncryptionReset/EncryptionResetScreen/EncryptionResetScreenViewModel.swift
Show resolved
Hide resolved
stefanceriu
force-pushed
the
stefan/3102
branch
from
August 2, 2024 14:32
c84c197
to
5214282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for resetting the user's crypto identity. This is to be used when the user cannot verify their device and no longer has access (or configured) their recovery key.
It will go through the steps of
On the app side this will most likely be invoked from the onboarding screens and, on successul reset, it will continue with the rest of the onboarding flows as normal.
Requires matrix-org/matrix-rust-sdk#3759 and matrix-org/matrix-rust-sdk#3790
Legacy:
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-08-02.at.10.10.47.mp4
OIDC:
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-08-02.at.10.09.49.mp4