Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto identity reset #3107

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Crypto identity reset #3107

merged 7 commits into from
Aug 5, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Aug 1, 2024

Add support for resetting the user's crypto identity. This is to be used when the user cannot verify their device and no longer has access (or configured) their recovery key.
It will go through the steps of

  • deleting existing backups
  • disabling recovery
  • requesting authorization (password or OIDC/MAS) and resetting crossigning
  • re-enabling backups (if allowed)

On the app side this will most likely be invoked from the onboarding screens and, on successul reset, it will continue with the rest of the onboarding flows as normal.

Requires matrix-org/matrix-rust-sdk#3759 and matrix-org/matrix-rust-sdk#3790

Legacy:

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-08-02.at.10.10.47.mp4

OIDC:

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-08-02.at.10.09.49.mp4

Copy link

github-actions bot commented Aug 1, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 5214282

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me. I think it would be nicer if we had a flow coordinator for all this, but not essential. That way we could add the flow (at least with a password) to the UI tests so we know it still works.

@stefanceriu stefanceriu marked this pull request as ready for review August 2, 2024 14:32
@stefanceriu stefanceriu requested a review from a team as a code owner August 2, 2024 14:32
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team August 2, 2024 14:32
@stefanceriu stefanceriu enabled auto-merge (squash) August 2, 2024 14:33
@stefanceriu stefanceriu added the pr-feature for a new feature label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 34.37500% with 294 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (276bbb0) to head (5214282).

Files Patch % Lines
...onResetScreen/EncryptionResetScreenViewModel.swift 6.36% 103 Missing ⚠️
...ResetScreen/EncryptionResetScreenCoordinator.swift 0.00% 47 Missing ⚠️
...reBackupScreen/SecureBackupScreenCoordinator.swift 0.00% 32 Missing ⚠️
...een/EncryptionResetPasswordScreenCoordinator.swift 0.00% 31 Missing ⚠️
...s/FlowCoordinators/OnboardingFlowCoordinator.swift 3.33% 29 Missing ⚠️
...creen/SecureBackupRecoveryKeyScreenViewModel.swift 27.77% 13 Missing ⚠️
...creen/EncryptionResetPasswordScreenViewModel.swift 26.66% 11 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 9 Missing ⚠️
...rdScreen/EncryptionResetPasswordScreenModels.swift 0.00% 6 Missing ⚠️
...ordScreen/View/EncryptionResetPasswordScreen.swift 92.15% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3107      +/-   ##
===========================================
- Coverage    78.05%   77.65%   -0.41%     
===========================================
  Files          705      713       +8     
  Lines        54584    54994     +410     
===========================================
+ Hits         42605    42704      +99     
- Misses       11979    12290     +311     
Flag Coverage Δ
unittests 68.34% <34.37%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 63e0b94 into develop Aug 5, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/3102 branch August 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants