Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonarcloud project key #3112

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

guillaumevillemont
Copy link
Contributor

For https://github.com/element-hq/sre-internal/issues/3184

Signed-off-by: Guillaume Villemont guillaumev@element.io

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@guillaumevillemont guillaumevillemont requested a review from a team as a code owner August 2, 2024 14:33
@guillaumevillemont guillaumevillemont requested review from pixlwave and removed request for a team August 2, 2024 14:33
Copy link

github-actions bot commented Aug 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 497e750

@guillaumevillemont guillaumevillemont added the pr-build for changes related to build, tools, CI/CD label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (276bbb0) to head (497e750).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3112      +/-   ##
===========================================
- Coverage    78.05%   78.01%   -0.05%     
===========================================
  Files          705      705              
  Lines        54584    54584              
===========================================
- Hits         42605    42582      -23     
- Misses       11979    12002      +23     
Flag Coverage Δ
unittests 68.47% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 2, 2024

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixlwave pixlwave merged commit cdaa88e into develop Aug 5, 2024
10 checks passed
@pixlwave pixlwave deleted the guillaumev/sonarcloud-rename branch August 5, 2024 08:38
@pixlwave
Copy link
Member

pixlwave commented Aug 5, 2024

@guillaumevillemont Are we able to migrate our customised Quality Profile from the old project to the new one? It is missing when I look in the dashboard.

@guillaumevillemont
Copy link
Contributor Author

@pixlwave Ho I'm sorry, I've tried to kept the same settings but I've missed that custom Quality Profile. The old project is now deleted, so it's lost :(

@pixlwave
Copy link
Member

pixlwave commented Aug 5, 2024

No worries, we'll take a look at the most common issues in the project, that should probably give us an idea of what we customised 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants